Skip to content

Arduino_LoRaWAN_*::NetBegin() functions don't call LMIC_setSession correctly #96

Closed
@terrillmoore

Description

@terrillmoore

Code review reveals that both Arduino_LoRaWAN_machineQ_base::NetBegin() and Arduino_LoRaWAN_ttn_base::NetBegin() call LMIC_setSession() with an incorect first parameter. It's annotated as /* port number */, and it's a constant value of 1. But that parameter is the NetID. Luckily this only matters for Class B in the LMIC; and we don't support that yet. But it should be fixed.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions