Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/lib/arduino_lorawan_cEventLog.cpp - processSingleEvent #191

Closed
surfermarty opened this issue Jun 5, 2022 · 1 comment
Closed

src/lib/arduino_lorawan_cEventLog.cpp - processSingleEvent #191

surfermarty opened this issue Jun 5, 2022 · 1 comment

Comments

@surfermarty
Copy link

processSingleEvent is marked as returning bool, returns false if the queue is empty, but doesn't return anything at the end of the code path. Assume it should return true on/at line 106

@terrillmoore
Copy link
Member

Yes, thanks. (At present, the function is private, and return result is never used by the only place it's called; so this is a latent but, rather than an actual fault. Still, this should be fixed.)

terrillmoore added a commit that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants