Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sign bit in uflt12f JavaScript decoder #901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlesech
Copy link

@jlesech jlesech commented Aug 27, 2022

Fix the uflt12f JavaScript decoder in README.

@terrillmoore
Copy link
Member

The uflt12f decoder is for unsigned floats, to save bits for values like relative humidity that can't physically take negative values. That's why the name begins with u. So this change is really not applicable. Also, sSign (where it was added in the patch), is it not in scope in the local the function, and will either cause a runtime error or will cause the sign to be set by unrelated global data.

The custom in this project is to put unrelated changes in different PRs, so the abp feather changes should be a different PR. Thanks!

@jlesech
Copy link
Author

jlesech commented Aug 27, 2022

I understand the goal of the uflt12f decoder :) But the goal of my PR is to remove it the sSign variable, not add it.

Sorry for the unrelated change, I did a mistake on my master branch. I removed the unrelated commit and I created another PR for the example sketch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants