Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #253: add AdcStart() before each AdcGetValue() #258

Merged
merged 6 commits into from
Jul 31, 2020
Merged

Fix #253: add AdcStart() before each AdcGetValue() #258

merged 6 commits into from
Jul 31, 2020

Conversation

dhineshkumarmcci
Copy link
Contributor

This pull-reuqest includes:

  • ADC code fix for ReadAnalog failure ReadAnalog fails #253
  • Update in Version number (last field)
  • Update in Revision history in README

terrillmoore
terrillmoore requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@terrillmoore terrillmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very minor, but we should get grammar right in new changes.

src/lib/stm32/stm32l0/CatenaStm32L0_ReadAnalog.cpp Outdated Show resolved Hide resolved
@terrillmoore terrillmoore merged commit 7620a89 into mcci-catena:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcciyssaroha mcciyssaroha mcciyssaroha approved these changes

@terrillmoore terrillmoore terrillmoore approved these changes

Assignees

@svelmurugan92 svelmurugan92

@terrillmoore terrillmoore

@mcciyssaroha mcciyssaroha

@dhineshkumarmcci dhineshkumarmcci

Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhineshkumarmcci @terrillmoore @mcciyssaroha @svelmurugan92