Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catena-Arduino-Platform is inconsistent in choice of network object #222

Closed
terrillmoore opened this issue Oct 3, 2019 · 0 comments
Closed

Catena-Arduino-Platform is inconsistent in choice of network object #222

terrillmoore opened this issue Oct 3, 2019 · 0 comments
Assignees
@terrillmoore
Labels
bug enhancement

Comments

@terrillmoore
Copy link
Member

The CatenaFeatherM0 object can be configured to use TTN or machineQ. All others are hardwired to TTN.

This means that none of the Murata-based modules can be used with non-TTN networks. Definitely a problem. Also, the UML diagram is wrong.

Move the FeatherM0 logic to Arduino_LoRaWAN, and use Ardunio_LoRaWAN_network as the encapsulating object.
@terrillmoore terrillmoore self-assigned this Oct 3, 2019
terrillmoore added a commit that referenced this issue Oct 3, 2019
@terrillmoore
Merge pull request #223 from mcci-catena/issue222
69bbd9b 
Fix #222: change all LoRaWAN classes to use Arduino_LoRaWAN_network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore