Skip to content

Fix: include subprojects' ignore and output directories to prevent rebuild loops in watch when using broadcast #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: include subprojects' ignore and output directories to prevent rebuild loops in watch when using broadcast #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac31fad
fix: improve ignore list handling in Project class
fewwan Oct 11, 2025
b997550
Merge branch 'mcbeet:main' into ignore-subprojects-output
fewwan Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions beet/toolchain/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,17 @@ def cache(self) -> ProjectCache:

@property
def ignore(self) -> List[str]:
ignore = list(self.config.ignore)
ignore = set(self.config.ignore)
if self.output_directory and self.directory in self.output_directory.parents:
ignore.append(
f"{self.output_directory.relative_to(self.directory).as_posix()}/"
)
return ignore
ignore.add(f"{self.output_directory.relative_to(self.directory).as_posix()}/")
for entry in self.config.pipeline:
if isinstance(entry, ProjectConfig):
ignore.update(entry.ignore)
if entry.output:
output_directory = Path(entry.output)
if entry.directory in output_directory.parents:
ignore.add(f"{output_directory.relative_to(entry.directory).as_posix()}/")
return list(ignore)

@property
def worker_pool(self):
Expand Down
Loading