-
-
Notifications
You must be signed in to change notification settings - Fork 416
Add translation progress script and GitHub Action #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Why not integrating this into the existing |
You're right. I didn’t want to overload the current script. I’ve made the changes, you can check the result here |
EMOJI_FLAGS="🇩🇪 🇪🇸 🇫🇷 🇮🇹 🇳🇱 🇨🇿 🇧🇷 🇪🇸 🇯🇵 🇷🇺 🇺🇦 🇵🇱" | ||
|
||
# [path|category_name] | ||
TS_FILES=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this part. It's not dynamic. If we add new ts files I need to remember about this.
The script already finds all the ts files depending on the build.
Can labels be like the folder name? like "fixtureeditor", "plugins/midi" and so on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can, but the result in the table will be very ugly. Maybe we can mix the two? We search for all .ts files, and if we know the path (TS_FILES), we get the friendly name, otherwise, we just put the path
Hi! This isn’t a functional change to QLC+, so I didn’t use the PR template this time.
I chatted with the maintainer of the QLC+ Instagram account, and he thought this was a great idea—so here’s a simple script to calculate the translation progress percentage for each language and module. It’s basic but does the job.
I’ve also added a GitHub Action that will run whenever a .ts file is modified in a PR, giving a quick update on the translation status. It might be nice to share this info more widely, though:
I placed the script into a new
scripts
folder. It might be a good idea to move all .sh files there to keep the root directory cleaner.Script Output:
Details