Skip to content

[GitHub][PR Decoration] Private Sonarqube server static images unavailable #130

Closed
@Brialius

Description

Describe the bug
Github uses https://camo.githubusercontent.com/ to proxy any user images on their side and this cannot be disabled. It means every image should be available for GitHub proxy server, which is impossible with the way of serving static images #80 for private hosted Sonarqube server behind a strict firewall.

To Reproduce
Steps to reproduce the behavior:

  1. Setup CE Branch plugin on a private Sonarqube server
  2. Use GitHub as a provider
  3. Run Sonarqube branch check
  4. See error

Expected behavior
Static images are available in GitHub PR checks for private and public accessible Sonarqube servers

Screenshots
If applicable, add screenshots to help explain your problem.
image

image

Software Versions

  • SonarQube Version: Version 7.9.2 (build 30863)
  • Plugin Version: 1.3.0

Additional context
Please return back function of com.github.mc1arke.sonarqube.plugin.branch.image-url-base and make it optional or provide other way to solve this issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions