Upgrade TypeScript and other minor JS dependencies #1452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana ticket: ⚙️ Upgrade TypeScript to 4.x
Most of the TypeScript upgrade itself was pretty straightforward. A couple of minor notes:
reload
. This is apparently only supported on Firefox and even then doesn't really do anything for our purposes (if there's a new version of the app, the fact that we're usingmix phx.digest
means the static assets will be at a different URL anyway). The types were causing issues so I went ahead and just removed the parameter.resize-observer-polyfill
package also had some issues, see here. However, from discussion with my PM we agreed to drop support for older browsers that don't have native ResizeObserver support (which would be pretty out-of-date at this point anyway). If this becomes an issue we can also use@juggle/resize-observer
, which seems better supported.