Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript and other minor JS dependencies #1452

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

lemald
Copy link
Member

@lemald lemald commented Mar 11, 2022

Asana ticket: ⚙️ Upgrade TypeScript to 4.x

Most of the TypeScript upgrade itself was pretty straightforward. A couple of minor notes:

  • We had been using an argument to reload. This is apparently only supported on Firefox and even then doesn't really do anything for our purposes (if there's a new version of the app, the fact that we're using mix phx.digest means the static assets will be at a different URL anyway). The types were causing issues so I went ahead and just removed the parameter.
  • The resize-observer-polyfill package also had some issues, see here. However, from discussion with my PM we agreed to drop support for older browsers that don't have native ResizeObserver support (which would be pretty out-of-date at this point anyway). If this becomes an issue we can also use @juggle/resize-observer, which seems better supported.
  • I also upgraded a handful of other JS dependencies that looked like low-hanging fruit.

@github-actions
Copy link

Coverage of commit f625aa3

Summary coverage rate:
  lines......: 94.8% (2314 of 2441 lines)
  functions..: 69.8% (997 of 1429 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link
Member

@boringcactus boringcactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lemald lemald merged commit 885a65d into master Mar 11, 2022
@lemald lemald deleted the lem-upgrade-typescript branch March 11, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants