Skip to content

Commit

Permalink
refactor: Update boostrap breakpoints and use them for u-hide-for-mob…
Browse files Browse the repository at this point in the history
…ile (#2778)
  • Loading branch information
joshlarson authored Sep 9, 2024
1 parent 4820fef commit 3c7f95f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
18 changes: 18 additions & 0 deletions assets/css/bootstrap/_variable_overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,21 @@ $ui-alert: semantic.$ui-alert;
$service-alert: semantic.$service-alert;
$light: new_tokens.$gray-50;
$dark: new_tokens.$gray-900;

// These breakpoints are overridden in order to match with our old set
// of breakpoints, defined in _skate_ui.scss. Our long-term goal is to
// replace our "custom" breakpoint system with these bootstrap
// breakpoints, and then possibly to change these values to match our
// forward-looking designs.
$grid-breakpoints: (
xs: 0,

// sm - Breakpoint between mobile and tablet
sm: 480px,

// md - Breakpoint between tablet and desktop
md: 800px,

// lg - Breakpoint between desktop and wide-screen desktop
lg: 1340px,
);
2 changes: 1 addition & 1 deletion assets/css/utilities/_hideable.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}

.u-hide-for-mobile {
@media screen and (max-width: map-get($breakpoints, "max-mobile-landscape-tablet-portrait-width")) {
@include media-breakpoint-down(md) {
display: none;
}
}

0 comments on commit 3c7f95f

Please sign in to comment.