Skip to content

Conversation

@thecristen
Copy link
Collaborator

Scope

Followup to #2903 which finishes the job.

Implementation

Most of this was accomplished by configuring Phoenix with the following in dev:

config :phoenix, :plug_init_mode, :runtime

Most of the rest was deprecating our call_plug macro with an equivalent arrangement which doesn't create compile-time dependencies.

How to test

This should ultimately not change how the application actually works.

  • mix xref graph --format cycles --label compile-connected returns No cycles found
  • Can deploy this and have all end to end tests passing.

@thecristen thecristen requested review from a team and amaisano as code owners January 29, 2026 19:33
@thecristen thecristen requested a review from joshlarson January 29, 2026 19:33
@thecristen thecristen added the dev-blue Deploy to dev-blue label Jan 30, 2026
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to actually run this yet (my internet connection is just not strong enough), but here are a few preliminary suggestions and comments. Nothing blocking so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-blue Deploy to dev-blue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants