Skip to content

Conversation

@joshlarson
Copy link
Contributor

Scope

Asana Ticket: ❗ [AM Alerts] Don't show train(s) specific alerts in stop page predictions pane

Implementation

  • Add a utility function to tell whether an alert isTripSpecific.
  • Update isDeparturesAndMapAlert to check both the alert effect and to check that an alert is not trip-specific.

Screenshots

Screenshot 2026-01-28 at 2 10 43 PM Screenshot 2026-01-28 at 2 11 30 PM

Also worth noting: When an alert is not trip-specific, then it will still be included in the predictions pane:

Screenshot 2026-01-28 at 2 18 21 PM

How to test

(If you're testing right now, 2:17PM on Wednesday Jan 28, then there are some helpful test alerts available - the ones pictured above. If you're testing at a different time, you may need to create test alerts that have the effects and specificities you're looking for)

Create a station bypass affecting one train on (for example) the Fall River/New Bedford line at (for example) Quincy Center. Visit the (for example) Quincy Center page. Observe that the No Service badge is no longer there.

Create a station bypass affecting all trains on (for example) the Fairmount Line at (for example) Uphams Corner. Visit the (for example) Upham's Corner page. Observe that the No Service badges are still there.

@joshlarson joshlarson requested a review from a team as a code owner January 28, 2026 19:26
@joshlarson joshlarson requested a review from thecristen January 28, 2026 19:26
@joshlarson joshlarson added the dev-green Deploy to dev-green label Jan 28, 2026
@joshlarson joshlarson merged commit 2233d63 into main Jan 30, 2026
16 of 17 checks passed
@joshlarson joshlarson deleted the jdl/fix/dont-show-train-specific-alerts-in-stop-page-predictions-pane branch January 30, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-green Deploy to dev-green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants