Make Material-UI a peer dependency?

[oliviertassinari]

What do you think of making Material-UI a peer dependency? You probably don't want people to bundle the library twice. It's what notistack and material-ui-pickers are doing.

[mbrn]

Of course i can. Just one thing. It makes development harder, reason of npm install --no-save @mate... everytime dependencies updated.

But i will do. I can change demo/test page as a another module by using lerna.

[oliviertassinari]

@mbrn I'm not 💯 sure it's the right approach either. A few points to take into account:

• We should take https://bundlephobia.com/result?p=material-table into account. Something might be wrong with tree shaking, it's a different problem.
• Bundling multiple versions of Material-UI can create class name mismatches and bundle bloat.
• It makes installation more painful. It's true.

[eps1lon]

Might be a good idea to specify the peer version of react as well.

[Foosballfan]

Strongly in favour of this, will save ~300KB by not bundling material-ui twice.

[eps1lon]

Strongly in favour of this, will save ~300KB by not bundling material-ui twice.

@Foosballfan You should be able to avoud this by resolving duplicate entries of @material-ui/core in your lockfile.

Bundling @material-ui/core twice can cause actual bugs (due to bundling @material-ui/styles twice).

[Foosballfan]

@eps1lon So you mean remove this entry within material-table dependencies from the package-lock.json manually?

"@material-ui/core": {
          "version": "3.9.3",
          "resolved": "https://registry.npmjs.org/@material-ui/core/-/core-3.9.3.tgz",
          ...
}

[eps1lon]

Only if they don't match i.e. if tables requires 3.x then you should also use 3.x. I can't give any guarantees that 3.x and 4.x in the same bundle works.

[Foosballfan]

Ok great, I made sure they matched exactly in the hope that webpack would treeshake better so no problem there.

Feels like a dodgy fix to edit an auto generated file!

Thanks for the tip

[eps1lon]

Feels like a dodgy fix to edit an auto generated file!

Well flattening trees is pretty hard so yarn will occasionally miss some optimizations. yarn check can help detect those.

[ryancogswell]

FYI -- someone encountering issues likely due to this (though they didn't provide a full reproduction of the problem so I can't be certain this is the cause):

https://stackoverflow.com/questions/56794892/material-table-styling-is-overiding-all-custom-and-material-ui-styling-and-icon

[ryancogswell]

FYI -- another user encountering issues related to this:

https://stackoverflow.com/questions/57204404/adding-component-with-material-table-changes-material-ui-appbar-style