Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Default Tools Pressure setting. #263

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Added Default Tools Pressure setting. #263

merged 2 commits into from
Mar 18, 2024

Conversation

tafode
Copy link
Contributor

@tafode tafode commented Mar 11, 2024

  • Added configuration to Settings Dialog
  • Circle, Line and Rectangle Tool pressure use the configured pressure instead of the constant 0.5

Should fix #212, #252 and #216

@tafode
Added Default Tools Pressure setting.
e9c7d38 
- Added configuration to Settings Dialog
- Circle, Line and Rectangle Tool pressure use the configured pressure instead of the constant 0.5
mbrlabs
mbrlabs requested changes Mar 17, 2024
View reviewed changes
Copy link
Owner

@mbrlabs mbrlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you!
Can you only use one call to Settings.get_value(Settings.GENERAL_TOOL_PRESSURE) though per function and save the pressure value in a local variable? Too much copy pasting here IMO.

@tafode
Copy link
Contributor Author

tafode commented Mar 17, 2024

You are right. I'll change it as soon as possible.

@tafode tafode requested a review from mbrlabs March 17, 2024 19:15
mbrlabs
mbrlabs approved these changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@mbrlabs mbrlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@mbrlabs mbrlabs merged commit a4c11c9 into mbrlabs:main Mar 18, 2024
3 checks passed
This was linked to issues Mar 18, 2024
Line thickness inconsistencies in Windows #252
Closed
The brush size is not equal to other tools size #216
Closed
This was referenced Mar 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrlabs mbrlabs mbrlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tafode @mbrlabs