Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux metadata files #203

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

DavidoTek
Copy link
Contributor

This PR adds metadata files required for packaging on Linux, for example Flatpak. See #17.

The files are currently stored in tinywrkb's Flatpak repo but it is recommended to have the files in the upstream repository so they are the same for all packages and can easily be modified by the upstream author.

Copy link
Owner

@mbrlabs mbrlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delay in review! Basically just some german translation issues.

Name=Lorien
GenericName=Note Taking
Comment=Infinite canvas drawing/whiteboarding app. Made with Godot.
Comment[de]=Unbegrenzte Zeichen- und Whiteboard-App. Erstellt mit Godot.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna use German here since this a german translation.

Unbegrenzte Zeichen- und Whiteboard-App hört sich irgendwie komisch an. So als ob es normal ein "Zeichenlimit" geben würde. Ich bin mir aber auch gerade nicht sicher wie man das am besten übersetzt. Vieleicht einfach "Infinite Whitboarding App". Das ist zwar kein deutsch, sollten die meisten aber verstehen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternativ einfach nur Zeichen- und Whiteboard-App oder Freie Zeichen- und Whiteboard-App (Frei im Sinne von kostenlos und unbegrenzt).


<name>Lorien</name>
<summary>Infinite canvas drawing/whiteboarding app. Made with Godot.</summary>
<summary xml:lang="de_DE">Unbegrenzte Zeichen- und Whiteboard-App. Erstellt mit Godot.</summary>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Type=Application
Name=Lorien
GenericName=Note Taking
Comment=Infinite canvas drawing/whiteboarding app. Made with Godot.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch the "Made with Godot". Irrelevant for the user.

@DavidoTek
Copy link
Contributor Author

I have changed the german description to Freie Zeichen- und Whiteboard-App and changed the mime type to x-lorien-canvas.

If there are no other changes, I can squash the commits.

Copy link
Owner

@mbrlabs mbrlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No it's fine, i can squash it when merging.

@mbrlabs mbrlabs merged commit b5aee8c into mbrlabs:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants