Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset tool state on tool change #155

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Reset tool state on tool change #155

merged 1 commit into from
Jun 16, 2022

Conversation

hansemro
Copy link
Contributor

Resolves #153

@hansemro hansemro marked this pull request as draft June 16, 2022 05:12
@hansemro

This comment was marked as outdated.

Sign in to view
@hansemro hansemro marked this pull request as ready for review June 16, 2022 05:48
@hansemro
Reset state of tool being switched
8f8409e 
Fixes (mbrlabs#153) "Segmentation fault when switching modes mid-stroke"
@hansemro
Copy link
Contributor Author

Cleaned up fix by having tools implement their own state reset function if it involves clearing additional objects.

@hansemro hansemro changed the title End stroke on tool change Reset tool state on tool change Jun 16, 2022
mbrlabs
mbrlabs approved these changes Jun 16, 2022
View reviewed changes
Copy link
Owner

@mbrlabs mbrlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good! Let me know when this is ready to merge

@hansemro
Copy link
Contributor Author

Ready to merge

@mbrlabs mbrlabs merged commit bc83fbe into mbrlabs:main Jun 16, 2022
@mbrlabs
Copy link
Owner

mbrlabs commented Jun 16, 2022

Thanks!

@hansemro hansemro deleted the tool-change-fix branch June 16, 2022 10:49
hansemro added a commit to hansemro/Lorien that referenced this pull request Dec 21, 2022
@hansemro
SelectionTool: fix missing cursor on initial usage
1d53693 
Fixes missing on-canvas cursor when switching to SelectionTool for the
first time.

Fixes: bc83fbe (`Reset state of tool being switched (mbrlabs#155)`)
mbrlabs pushed a commit that referenced this pull request Aug 5, 2023
@hansemro
SelectionTool: fix missing cursor on initial usage (#215)
278f61a 
Fixes missing on-canvas cursor when switching to SelectionTool for the
first time.

Fixes: bc83fbe (`Reset state of tool being switched (#155)`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrlabs mbrlabs mbrlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when switching modes mid-stroke
2 participants
@hansemro @mbrlabs