Skip to content

Commit

Permalink
Changes:
Browse files Browse the repository at this point in the history
1. Added Linter
2. Added Prettier
3. Added pre-commit hook to run test, prettier and linter
4. Added badges like code style, downloads and license
  • Loading branch information
muthurathinam-m committed Feb 1, 2019
1 parent ada88f7 commit 143a5e0
Show file tree
Hide file tree
Showing 119 changed files with 11,047 additions and 10,297 deletions.
25 changes: 13 additions & 12 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,31 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

### Prerequisites
# Bug Report

## Prerequisites

* [ ] Can you reproduce the problem?
* [ ] Are you running the latest version?
* [ ] Are you reporting to the correct repository?
* [ ] Did you perform a cursory search?
- [ ] Can you reproduce the problem?
- [ ] Are you running the latest version?
- [ ] Are you reporting to the correct repository?
- [ ] Did you perform a cursory search?

For more information, see the `CONTRIBUTING` guide.

### Description
## Description

[Description of the bug or feature]

**Console Errors:** [Is there any console error]

**Screenshots:** [If applicable, add screenshots to help explain your problem]

### Steps to Reproduce
## Steps to Reproduce

1. [First Step]
2. [Second Step]
Expand All @@ -34,6 +35,6 @@ For more information, see the `CONTRIBUTING` guide.

**Actual behavior:** [What actually happened]

### Additional context
## Additional context

Add any other context about the problem here..
21 changes: 13 additions & 8 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,25 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

**Is your feature request related to a problem? Please describe.**
# Feature Request

## Is your feature request related to a problem? Please describe

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
## Describe the solution you'd like

A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
## Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
## Additional context

Add any other context or screenshots about the feature request here.
25 changes: 14 additions & 11 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
A similar PR may already be submitted!
Please search among the [Pull request](https://github.com/microsoftgraph/msgraph-sdk-javascript/pulls) before creating one.
A similar PR may already be submitted! Please search among the [Pull request](https://github.com/microsoftgraph/msgraph-sdk-javascript/pulls) before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.

Expand All @@ -22,18 +21,22 @@ Demonstrate the code is solid. Example: The exact commands you ran and their out
## Closing issues

<!-- Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). -->

Fixes #

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Checklist
- [ ] I have read the **CONTRIBUTING** document.
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

- [ ] I have read the **CONTRIBUTING** document.
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
5 changes: 5 additions & 0 deletions .huskyrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"hooks": {
"pre-commit": "npm run lint && npm run format && npm run build && npm run test"
}
}
2 changes: 1 addition & 1 deletion .jshintrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"esnext": "true"
}
}
9 changes: 9 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
lib/

src/**/*.js
src/**/*.js.map
src/**/*.d.ts

spec/**/*.js
spec/**/*.js.map
spec/**/*.d.ts
13 changes: 13 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"arrowParens": "always",
"bracketSpacing": true,
"jsxBracketSameLine": true,
"jsxSingleQuote": false,
"printWidth": 5000,
"proseWrap": "never",
"semi": true,
"singleQuote": false,
"tabWidth": 4,
"trailingComma": "all",
"useTabs": true
}
113 changes: 59 additions & 54 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -1,56 +1,61 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Run node samples",
"program": "${workspaceRoot}/samples/node/main.js",
"cwd": "${workspaceRoot}",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run core tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": [
"${workspaceRoot}/lib/spec/core/*.js"
],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run workload tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": [
"${workspaceRoot}/spec/development/workload/*.js"
],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run middleware tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": [
"${workspaceRoot}/spec/middleware/*.js"
],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
}
]
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Run node samples",
"program": "${workspaceRoot}/samples/node/main.js",
"cwd": "${workspaceRoot}",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run core tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": ["${workspaceRoot}/lib/spec/core/*.js"],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run workload tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": ["${workspaceRoot}/spec/development/workload/*.js"],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run middleware tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": ["${workspaceRoot}/lib/spec/middleware/*.js"],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Run Content tests",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"args": ["${workspaceRoot}/lib/spec/content/*.js"],
"cwd": "${workspaceRoot}",
"preLaunchTask": "Run Build",
"outFiles": [],
"internalConsoleOptions": "openOnSessionStart"
}
]
}
24 changes: 12 additions & 12 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
{
"label": "Run Build",
"type": "npm",
"script": "build",
"group": "build"
}
]
}
// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
{
"label": "Run Build",
"type": "npm",
"script": "build",
"group": "build"
}
]
}
Loading

0 comments on commit 143a5e0

Please sign in to comment.