Improve JS type checking, bump vitest and others #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds upon my recent experience improving the type checking in: - mbland/jsdoc-cli-wrapper - mbland/test-page-opener - mbland/rollup-plugin-handlebars-precompiler Switched from jsconfig.json to tsconfig.json, which seems to be better supported by default. Moved a bunch of `tsc` compiler options to that file and updated the `pnpm typecheck` script accordingly. The generated JSDoc output still isn't the greatest, but the Visual Studio Code and IntelliJ IDEA type checking and documentation is pretty good now. I may have to circle back to improving the JSDoc output later, but I need a break from it for now. Also, bumped vitest to v1.2.1, along with a couple other module versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon my recent experience improving the type checking in:
Switched from jsconfig.json to tsconfig.json, which seems to be better supported by default. Moved a bunch of
tsccompiler options to that file and updated thepnpm typecheckscript accordingly.The generated JSDoc output still isn't the greatest, but the Visual Studio Code and IntelliJ IDEA type checking and documentation is pretty good now. I may have to circle back to improving the JSDoc output later, but I need a break from it for now.
Also, bumped vitest to v1.2.1, along with a couple other module versions.