Merged
Conversation
sferik
force-pushed
the
rspec-4
branch
3 times, most recently
from
ec44c0c to
b2208b5
Compare
sferik
force-pushed
the
rspec-4
branch
2 times, most recently
from
1384882 to
07b4b47
Compare
sferik
force-pushed
the
rspec-4
branch
3 times, most recently
from
1908539 to
7845cdc
Compare
This caused two failures in the latest version of RuboCop, which are also corrected in this commit. Also, fix parser round trip test ordering bug and exclude character_literal fixture.
* Remove --color from .rspec (removed in RSpec 4) * Replace bare `describe` with `RSpec.describe` at top level * Replace `it_should_behave_like` with `it_behaves_like` * Replace `should`/`should_not` with `is_expected.to`/`is_expected.not_to`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
describewithRSpec.describeat top levelit_should_behave_likewithit_behaves_likeshould/should_notwithis_expected.to/is_expected.not_to