Skip to content

Tighten Ruby version requirement to avoid Symbol#inspect bug in previous versions #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prikha wants to merge 3 commits into from
Closed

Tighten Ruby version requirement to avoid Symbol#inspect bug in previous versions #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e803fee
Tighten Ruby version requirement to avoid:
prikha Jan 18, 2024
b9f52ba
Add test example
prikha Jan 18, 2024
b833e12
Remove unsupported Ruby versions from CI
prikha Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ruby-3.0, ruby-3.1, ruby-3.2, ruby-3.3]
ruby: [ruby-3.2, ruby-3.3]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand All @@ -35,7 +35,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ruby-3.0, ruby-3.1, ruby-3.2, ruby-3.3]
ruby: [ruby-3.2, ruby-3.3]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand All @@ -53,7 +53,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ruby-3.0, ruby-3.1, ruby-3.2, ruby-3.3]
ruby: [ruby-3.2, ruby-3.3]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand All @@ -69,7 +69,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ruby-3.0, ruby-3.1, ruby-3.2, ruby-3.3]
ruby: [ruby-3.2, ruby-3.3]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand All @@ -85,7 +85,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ruby-3.0, ruby-3.1, ruby-3.2, ruby-3.3]
ruby: [ruby-3.2, ruby-3.3]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 3 additions & 0 deletions spec/unit/unparser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,9 @@ def noop
"false"
end
RUBY

# Test for Symbol#inspect bug: https://bugs.ruby-lang.org/issues/18905
assert_source(':"8 >="')
end

describe 'corpus' do
Expand Down
2 changes: 1 addition & 1 deletion unparser.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Gem::Specification.new do |gem|

gem.metadata['rubygems_mfa_required'] = 'true'

gem.required_ruby_version = '>= 3.0'
gem.required_ruby_version = '>= 3.2'
Copy link
Owner

@mbj mbj Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot remove support for 3.0 and 3.1 right now. Not until they are EOL. I'll have to fix this via a conditional around the Symbol#inspect usage.


gem.add_dependency('diff-lcs', '~> 1.3')
gem.add_dependency('parser', '>= 3.3.0')
Expand Down