Fix named group mutations #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
force-pushed
the
fix-named_group-mutations
branch
2 times, most recently
from
1601936
to
f6ab614
Compare
- Regular expressions such as `/(?<name>\w\d)/` would only end up mutating the part of the group (ex: `/(?<name>\W\d)/` but not `/(?<name>\w\D)/`). This change fixes that error and mutates over all children of the named capture group.
dgollahon
force-pushed
the
fix-named_group-mutations
branch
from
f6ab614
to
dc7a657
Compare
mbj
approved these changes
May 2, 2022
dgollahon
added a commit
that referenced
this pull request
May 2, 2022
- Fix incomplete mutations for regexp capture groups. As an example, `/(\w\d)/` now gets mutated to `/(\W\d)/` and `/(\w\D)/` instead of just the former case. - Likewise, fix capture group -> passive group mutations which would not get properly generated in many cases. As an example, `/(\w\d)/` woudl get mutated to `/(?\w)/` instead of `/(?:\w\d)/` like it will now. - Closely related to #1328
dgollahon
added a commit
that referenced
this pull request
May 2, 2022
- Fix incomplete mutations for regexp capture groups. As an example, `/(\w\d)/` now gets mutated to `/(\W\d)/` and `/(\w\D)/` instead of just the former case. - Likewise, fix capture group -> passive group mutations which would not get properly generated in many cases. As an example, `/(\w\d)/` woudl get mutated to `/(?\w)/` instead of `/(?:\w\d)/` like it will now. - Closely related to #1328
dgollahon
added a commit
that referenced
this pull request
May 2, 2022
- Fix incomplete mutations for regexp capture groups. As an example, `/(\w\d)/` now gets mutated to `/(\W\d)/` and `/(\w\D)/` instead of just the former case. - Likewise, fix capture group -> passive group mutations which would not get properly generated in many cases. As an example, `/(\w\d)/` would get mutated to `/(?\w)/` instead of `/(?:\w\d)/` like it will now. - Closely related to #1328
dgollahon
added a commit
that referenced
this pull request
May 2, 2022
- Fix incomplete mutations for regexp capture groups. As an example, `/(\w\d)/` now gets mutated to `/(\W\d)/` and `/(\w\D)/` instead of just the former case. - Likewise, fix capture group -> passive group mutations which would not get properly generated in many cases. As an example, `/(\w\d)/` would get mutated to `/(?:\w)/` instead of `/(?:\w\d)/` like it will now. - Closely related to #1328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/(?<name>\w\d)/would only end up mutating the part of the group (ex:/(?<name>\W\d)/but not/(?<name>\w\D)/). This change fixes that error and mutates over all children of the named capture group.