Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Fixes bug on Android/Chrome because Android does not sends the correct keyCode #692

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gnarvaja
Copy link

@gnarvaja gnarvaja commented Jul 4, 2016

Manually detects comma from the input text.

@dprea
Copy link

dprea commented Aug 23, 2016

@gnarvaja The travis report shows you only need to change '==' to '===' on line 416 to pass the tests.

I have tested this code in Chrome Desktop and Android Chrome and it does seem to fix the problem with comma.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.336% when pulling 46f609b on lambdasistemas:master into af9feb7 on mbenford:master.

@SammyIsra
Copy link

Was the problem that it would not detect when a user on Android or Chrome pressed the comma key? If that is the case, I am experiencing something similar.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.336% when pulling a467d2c on lambdasistemas:master into af9feb7 on mbenford:master.

@calebfaruki
Copy link

This getting merged anytime soon?

@mikesnare
Copy link

Just wanted to note that this is not working for me. Not sure how it works for anyone. First, it only handles the comma case but the component supports space and enter as well. Second, and more importantly, because this runs during the keydown event, the input has not been updated with the key that was pressed. I.e. if the value of the input field is a@b.com and you type the comma, the comma is not part of the value during the event. The value is still a@b.com because the keydown happens before the value is updated. You'd need to type the comma again, and then it would work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants