Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add folder to translations #30

Merged
merged 8 commits into from
Sep 25, 2017
Merged

add folder to translations #30

merged 8 commits into from
Sep 25, 2017

Conversation

wwwmarcos
Copy link
Contributor

No description provided.

mbeaudru
mbeaudru reviewed Sep 25, 2017
View reviewed changes
Copy link
Owner

@mbeaudru mbeaudru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Would you mind renaming the folder "i18n" for "translations" ? I want to be sure beginners understand that translations are in this folder, since everybody doesn't know what i18n means.

I will gladly approve the PR after that change, nice work!

@mbeaudru mbeaudru merged commit 2c0241b into mbeaudru:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeaudru mbeaudru mbeaudru left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwmarcos @mbeaudru