Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert xrdb to VS Code format #312

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

jdhmtl
Copy link
Collaborator

@jdhmtl jdhmtl commented Jun 18, 2021

There is an existing Powershell script that does this, but I updated the Python script (which was actually a copy of the Windows Terminal converter) so as to be easily callable from update_all.py. Closes #307

@jdhmtl
Copy link
Collaborator Author

jdhmtl commented Jun 18, 2021

I have taken care to minimize the impact on existing VS Code schemes, mostly to prevent having a giant PR to review. The current implementation does remove the trailing comma from the resultant JSON output, though, so a subsequent PR will add missing VS Code themes, and have a bunch of changed files where the only change is the dropped trailing comma. I know that's a little annoying, which is why I explicitly haven't included the updated themes here.

@mbadolato mbadolato merged commit b832ebb into mbadolato:master Jun 19, 2021
@mbadolato
Copy link
Owner

Thanks!

@jdhmtl jdhmtl deleted the vs-code-converter branch June 19, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code and Windows Terminal converters are identical
2 participants