Add cursor selection color to windows vscode #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windowsterminal uses cursorColor and selectionBackground see https://docs.microsoft.com/en-us/windows/terminal/customize-settings/color-schemes vscode uses terminal.selectionBackground and terminalCursor.foreground see https://code.visualstudio.com/api/references/theme-color#integrated-terminal-colors
5 tasks
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windowsterminal uses cursorColor and selectionBackground
see https://docs.microsoft.com/en-us/windows/terminal/customize-settings/color-schemes
vscode uses terminal.selectionBackground and terminalCursor.foreground
see https://code.visualstudio.com/api/references/theme-color#integrated-terminal-colors
I also ran update and then the ./windowsterminal2vscode.ps1 in powershell (using
docker run -v "$(pwd)":/schemes -it mcr.microsoft.com/powershellfor help). As a result, all the windowsterminal and vscode themes got updated, and a number of new themes that were added since the last run of update.This addresses #240