Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#459 reassigning #462

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Issue/#459 reassigning #462

merged 6 commits into from
Oct 29, 2024

Conversation

svenvandescheur
Copy link
Contributor

@svenvandescheur svenvandescheur commented Oct 25, 2024

2024-10-25: Test and refactor only, need implementation
2024-10-28: Ready for review

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 9.00000% with 182 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (609b373) to head (0c55402).

Files with missing lines Patch % Lines
...wPage/DestructionListProcessReviewPage.stories.tsx 0.00% 44 Missing ⚠️
...ction/tests/e2e/issues/test_459_update_reviewer.py 20.93% 34 Missing ⚠️
...ckend/src/openarchiefbeheer/utils/tests/gherkin.py 20.00% 12 Missing ⚠️
...estructionListReviewer/DestructionListReviewer.tsx 0.00% 11 Missing and 1 partial ⚠️
frontend/src/hooks/useAuditLog.ts 0.00% 10 Missing and 1 partial ⚠️
frontend/src/hooks/useLatestReviewResponse.ts 0.00% 9 Missing and 2 partials ⚠️
...ction/tests/e2e/features/test_feature_list_edit.py 0.00% 9 Missing ⚠️
...s/destructionlist/detail/DestructionListDetail.tsx 0.00% 7 Missing and 2 partials ⚠️
frontend/src/hooks/useReviewers.ts 0.00% 8 Missing ⚠️
frontend/src/hooks/useWhoAmI.ts 0.00% 8 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   76.40%   75.94%   -0.47%     
==========================================
  Files         263      268       +5     
  Lines        8816     8879      +63     
  Branches      179      182       +3     
==========================================
+ Hits         6736     6743       +7     
- Misses       1920     1973      +53     
- Partials      160      163       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenvandescheur svenvandescheur force-pushed the issue/#459-reassigning branch 2 times, most recently from 05b9cfd to 57a1c03 Compare October 28, 2024 11:24
@svenvandescheur svenvandescheur marked this pull request as ready for review October 28, 2024 11:32
@svenvandescheur svenvandescheur merged commit 00238bd into main Oct 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants