✅ - test: attempt to fix the tests

maykinmedia · Oct 21, 2024 · 8f15fa4 · 8f15fa4
1 parent 1e58dc8
commit 8f15fa4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/backend/src/openarchiefbeheer/destruction/tests/e2e/features/test_feature_list_create.py b/backend/src/openarchiefbeheer/destruction/tests/e2e/features/test_feature_list_create.py
@@ -62,9 +62,7 @@ async def test_scenario_reviewer_cannot_create_list(self):
 
             await self.when.reviewer_logs_in(page)
             await self.then.path_should_be(page, "/destruction-lists")
-
-            await self.when.user_clicks_button(page, "Vernietigingslijst opstellen")
-            await self.then.path_should_be(page, "/login?next=/destruction-lists/create")
+            await self.then.not_.page_should_contain_text(page, "Vernietigingslijst opstellen")
 
     async def test_scenario_archivist_cannot_create_list(self):
         async with browser_page() as page:
@@ -73,9 +71,7 @@ async def test_scenario_archivist_cannot_create_list(self):
 
             await self.when.archivist_logs_in(page)
             await self.then.path_should_be(page, "/destruction-lists")
-
-            await self.when.user_clicks_button(page, "Vernietigingslijst opstellen")
-            await self.then.path_should_be(page, "/login?next=/destruction-lists/create")
+            await self.then.not_.page_should_contain_text(page, "Vernietigingslijst opstellen")
 
     async def test_zaaktype_filters_on_create_page(self):
 

diff --git a/backend/src/openarchiefbeheer/utils/tests/gherkin.py b/backend/src/openarchiefbeheer/utils/tests/gherkin.py
@@ -479,7 +479,7 @@ def get_number_of_items():
 
         async def page_should_contain_text(self, page, text):
             locator = page.get_by_text(text).nth(0)
-            await expect(locator).to_be_attached()
+            await expect(locator).to_be_visible()
 
         async def path_should_be(self, page, path):
             await self.url_should_be(page, self.testcase.live_server_url + path)