Feature/564 open objecten #713

Floris272 · 2025-12-24T11:21:34Z

Fixes #564

Changes

fully integrates objecttypes api into objects api
removes code used for fetching external objecttypes
adds upgrade check to make sure all objecttypes are imported

TODO

docs. install & readme

src/objects/core/forms.py

github-actions · 2025-12-24T11:29:00Z

Bencher Report

Branch	feature/564-open-objecten
Testbed	ubuntu-latest

🚨 1 Alert

Benchmark	Measure Units	View	Benchmark Result (Result Δ%)	Upper Boundary (Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1	Latency milliseconds (ms)	📈 plot 🚷 threshold 🚨 alert (🔔)	417.18 ms (+16.55%) Baseline: 357.94 ms	375.84 ms (111.00%)

Click to view all benchmark results

Benchmark	Latency	Benchmark Result milliseconds (ms) (Result Δ%)	Upper Boundary milliseconds (ms) (Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type	📈 view plot 🚷 view threshold	123.40 ms (+0.64%) Baseline: 122.61 ms	128.74 ms (95.85%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result	📈 view plot 🚷 view threshold	20.25 ms (-8.44%) Baseline: 22.11 ms	23.22 ms (87.20%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1	📈 view plot 🚷 view threshold 🚨 view alert (🔔)	417.18 ms (+16.55%) Baseline: 357.94 ms	375.84 ms (111.00%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5	📈 view plot 🚷 view threshold	330.04 ms (+4.94%) Baseline: 314.49 ms	330.22 ms (99.95%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20	📈 view plot 🚷 view threshold	126.69 ms (-2.71%) Baseline: 130.22 ms	136.73 ms (92.66%)

🐰 View full continuous benchmarking report in Bencher

codecov-commenter · 2026-01-07T13:27:15Z

Codecov Report

❌ Patch coverage is 96.86684% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.58%. Comparing base (85f0862) to head (d9f47d4).

Files with missing lines	Patch %	Lines
src/objects/utils/autoschema.py	33.33%	6 Missing ⚠️
src/objects/core/forms.py	89.18%	3 Missing and 1 partial ⚠️
src/objects/core/models.py	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   84.98%   85.58%   +0.60%     
==========================================
  Files         141      144       +3     
  Lines        2843     3018     +175     
  Branches      224      238      +14     
==========================================
+ Hits         2416     2583     +167     
- Misses        375      382       +7     
- Partials       52       53       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Floris272 · 2026-01-08T10:15:13Z

docker/setup_configuration/data.yaml

-            '1':
-              - record__data__leeftijd
-              - record__data__kiemjaar
+# TODO


removed the objecttype setup config thing but because of that you cannot really add permissions anymore, should it be added back and if yes only the required objecttype fields or everything?

What's the reason for removing it? Is it because you can't create ObjectTypes now without specifying the JSON schema?

Yes, the original use case was to only set the name and service so that all versions with their json schema's will be accesible, then in a tokenauth fields can be specified.

After the objecttype move, we could keep it as just the name, but then specifying the tokenauth permission fields becomes weird because that the schema cannot be defined in in the setup conf.

So i would propose to either:

remove objecttypes from setup config.

add the bare minimum (name, name_plural is also required but can be derived) but remove the token auth permission fields.

add version and schema to objecttype config but i feel like objecttype versions should not be created like this.

Let's go for the second option for now

Floris272 · 2026-01-08T10:16:22Z

src/objects/core/models.py

        help_text=_("Incremental index number of the object record."),
    )
    object = models.ForeignKey(Object, on_delete=models.CASCADE, related_name="records")
    version = models.PositiveSmallIntegerField(


version could become an FK?

src/objects/core/management/commands/import_objecttypes.py

src/objects/api/serializers.py

stevenbal

Looks good overall 👍

src/objects/tests/v2/test_filters.py

src/objects/tests/v2/test_validation.py

src/objects/api/v2/openapi.yaml

stevenbal · 2026-01-09T15:20:08Z

src/objects/conf/base.py

+UPGRADE_CHECK_PATHS: UpgradePaths = {
+    "4.0.0": UpgradeCheck(
+        VersionRange(minimum="3.6.0"),
+        code_checks=[CommandCheck("check_for_external_objecttypes")],
+    ),
+}


I'm a bit confused about this one: I know this check is run before migrations, but we probably have to include this check + the command in 3.6.0 right? Otherwise this code can't be run before you actually upgrade to 4.0.0 and by the time that you do ObjectType.is_imported is already removed from the code

You're right that is_imported is already removed then, i think the fix is to remove is imported in 4.1.0 and add another check that 4.0.0 becomes the minimum for 4.1.0.

src/objects/api/v2/openapi.yaml

stevenbal · 2026-01-09T15:38:41Z

docker/setup_configuration/data.yaml

-            '1':
-              - record__data__leeftijd
-              - record__data__kiemjaar
+# TODO


What's the reason for removing it? Is it because you can't create ObjectTypes now without specifying the JSON schema?

src/objects/api/v2/openapi.yaml

stevenbal · 2026-01-09T15:42:36Z

@Floris272 will you do the docs in a separate PR?

Floris272 · 2026-01-27T14:45:56Z

src/objects/core/management/commands/import_objecttypes.py

-                "service",
-            ],  # TODO remove service from unique_fields after objecttype migration since it will no longer be part of the ObjectType model.


Command could be kept, Objecttypes will just be unique on their uuid only

Floris272 · 2026-01-27T15:19:06Z

@Floris272 will you do the docs in a separate PR?

yes

stevenbal

Some small things remaining still, I'd recommend to split off the duplicate UUID stuff into a separate PR, because this PR has been open for quite a while already

src/objects/api/serializers.py

src/objects/conf/api.py

src/objects/core/management/commands/import_objecttypes.py

src/objects/utils/oas_extensions/fields.py

stevenbal · 2026-02-09T11:40:50Z

src/objects/core/management/commands/check_for_external_objecttypes.py

+        for objecttype in ObjectType.objects.iterator():
+            if not objecttype.is_imported:
+                external_object_count += 1
+                service.add(objecttype.service)


This fails currently, because service was removed from the ObjectType model
web-init-1 | File "/app/src/objects/core/management/commands/check_for_external_objecttypes.py", line 23, in handle
web-init-1 | service.add(objecttype.service)
web-init-1 | ^^^^^^^^^^^^^^^^^^
web-init-1 | AttributeError: 'ObjectType' object has no attribute 'service'

Let's instead output the UUID or names of the Objecttypes that were not imported yet

Could you also make sure there is a test for this?

stevenbal · 2026-02-09T11:49:30Z

docker/setup_configuration/data.yaml

-            '1':
-              - record__data__leeftijd
-              - record__data__kiemjaar
+# TODO


Let's go for the second option for now

… only

…VERSION_CACHE_TIMEOUT

github-actions · 2026-02-10T15:25:03Z

Bencher Report

Branch	feature/564-open-objecten
Testbed	ubuntu-24.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result milliseconds (ms) (Result Δ%)	Upper Boundary milliseconds (ms) (Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type	📈 view plot 🚷 view threshold	121.91 ms (-0.94%) Baseline: 123.07 ms	129.22 ms (94.34%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result	📈 view plot 🚷 view threshold	18.55 ms (-9.86%) Baseline: 20.58 ms	21.61 ms (85.85%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1	📈 view plot 🚷 view threshold	327.06 ms (+4.07%) Baseline: 314.28 ms	329.99 ms (99.11%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5	📈 view plot 🚷 view threshold	326.21 ms (+4.45%) Baseline: 312.31 ms	327.93 ms (99.48%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20	📈 view plot 🚷 view threshold	122.65 ms (-2.78%) Baseline: 126.16 ms	132.47 ms (92.59%)

🐰 View full continuous benchmarking report in Bencher

github-advanced-security bot found potential problems Dec 24, 2025

View reviewed changes

src/objects/core/forms.py Dismissed Show dismissed Hide dismissed

Floris272 force-pushed the feature/564-open-objecten branch from 273b407 to 587f7e5 Compare January 7, 2026 13:24

Floris272 commented Jan 8, 2026

View reviewed changes

Floris272 marked this pull request as ready for review January 8, 2026 10:56

Floris272 requested a review from stevenbal January 8, 2026 10:56

stevenbal requested changes Jan 9, 2026

View reviewed changes

stevenbal mentioned this pull request Jan 26, 2026

Prepare Objects release 3.6.0 #720

Closed

16 tasks

Floris272 force-pushed the feature/564-open-objecten branch from b4b24a2 to d81a31c Compare January 27, 2026 14:27

Floris272 commented Jan 27, 2026

View reviewed changes

Floris272 requested review from CharString and stevenbal January 27, 2026 15:19

Floris272 force-pushed the feature/564-open-objecten branch 2 times, most recently from 5a4d32e to d673439 Compare February 3, 2026 09:17

stevenbal requested changes Feb 9, 2026

View reviewed changes

Floris272 force-pushed the feature/564-open-objecten branch from d673439 to 8214fae Compare February 9, 2026 14:16

Floris272 added 11 commits February 10, 2026 16:03

📝 [#564] add objecttypes code

465b8ed

✨ [#564] add upgrade check and transform objecttype model to internal…

fa23efb

… only

🔥 [#564] remove objecttype fetch code and fix tests

b9de99f

💚 [#564] fix ci

1e47d4a

♻️ [#564] update ObjectTypeVersionFactory data and remove OBJECTTYPE_…

2cb188f

…VERSION_CACHE_TIMEOUT

✅ [#564] fix default test objecttype JSON_SCHEMA

5c9305e

✅ [#564] fix factory dict assignment

681ea8b

💚 [#564] remove objecttype from example setup config data

be8b0a4

♻️ [#564] add requested changes

9d90670

♻️ [#564] regenerate migration

8b77580

✅ [#564] remove linkable_to_zaken from tests

b4897ba

Floris272 added 4 commits February 10, 2026 16:03

♻️ [#564] add back objecttype config step

9d40155

✅ [#564] fix upgrade check

79a344c

✅ [#564] add unique validator to objecttype uuid serializer

eb8bd6b

✅ [#564] enable ObjectTypesConfigurationStep

d9f47d4

Floris272 force-pushed the feature/564-open-objecten branch from 5e51c56 to d9f47d4 Compare February 10, 2026 15:15

Floris272 requested a review from stevenbal February 10, 2026 16:15

		"service",
		], # TODO remove service from unique_fields after objecttype migration since it will no longer be part of the ObjectType model.

Feature/564 open objecten #713

Are you sure you want to change the base?

Feature/564 open objecten #713

Uh oh!

Conversation

Floris272 commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 1 Alert

Uh oh!

codecov-commenter commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stevenbal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevenbal commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Floris272 commented Jan 27, 2026

Uh oh!

stevenbal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Floris272 commented Dec 24, 2025 •

edited

Loading

github-actions bot commented Dec 24, 2025 •

edited

Loading

codecov-commenter commented Jan 7, 2026 •

edited

Loading