Skip to content

Fix/volume unmute to original value #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laoluogun wants to merge 6 commits into
base: dev
Choose a base branch
from
+15 −2
Open

Fix/volume unmute to original value #2274

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d923561
Remember previous volume value when muting
laoluogun Jul 23, 2026
315fa9f
Remember previous volume value when muting
laoluogun Jul 23, 2026
f197fac
Merge remote-tracking branch 'origin/fix/volume-unmute-to-original-va…
laoluogun Jul 23, 2026
475ea01
Fix else formatting
laoluogun Jul 23, 2026
b85cc7f
Initiliaze previous volume to 10%
laoluogun Jul 25, 2026
9f0dccd
Add cap to volume value when unmuting
laoluogun Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions composeApp/src/commonMain/kotlin/com/maxrave/simpmusic/ui/screen/MiniPlayer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,11 +841,23 @@ fun MiniPlayer(
)
}
}
var previousVolumeValue by rememberSaveable {
mutableFloatStateOf(controllerState.volume.coerceAtLeast(0.1f))
}
LaunchedEffect(controllerState.volume) {
if (controllerState.volume > 0f) {
previousVolumeValue = controllerState.volume
}
}
IconButton(
onClick = {
// Toggle mute/unmute
val newVolume = if (controllerState.volume > 0f) 0f else 1f
sharedViewModel.onUIEvent(UIEvent.UpdateVolume(newVolume))
if (controllerState.volume > 0f) {
previousVolumeValue = controllerState.volume
sharedViewModel.onUIEvent(UIEvent.UpdateVolume(0f))
} else {
sharedViewModel.onUIEvent(UIEvent.UpdateVolume(previousVolumeValue.coerceIn(0.1f, 1f)))
}
},
) {
Icon(
Expand Down Expand Up @@ -882,6 +894,7 @@ fun MiniPlayer(
onValueChange = {
isVolumeSliding = true
volumeValue = it
if (it > 0f) previousVolumeValue = it
},
valueRange = 0f..1f,
modifier =
Expand Down
Loading