Skip to content

fix: nginx config from 'sites-enabled' instead of 'sites-available' #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2017
Merged

fix: nginx config from 'sites-enabled' instead of 'sites-available' #48

merged 1 commit into from
Apr 26, 2017

Conversation

stefankoerner
Copy link
Contributor

No description provided.

@maxpou
Copy link
Owner

maxpou commented Mar 14, 2017

Hi, can you provide more details please?

@SebTM
Copy link

SebTM commented Mar 21, 2017

I'm not the creator of the PR but I think I can explain it to you just as well:
As you can see in your nginx-Dockerfile (https://github.com/maxpou/docker-symfony/blob/master/nginx/Dockerfile) your are doing it really well by symlinking the symony-config to sites-enabled and removing the default config from there.

The Problem from know is that you are including all files under "/etc/nginx/sites-available/*" instead of "sites-enabled".

Another suggestion would be to extend the include-statement by only including "*.conf" files from "sites-enabled" as far as I know this whould be the default behaviour.

@davidbonachera
Copy link

In a more practical way it means thats if you can't match the server_name by adding the ip your host file, it will end up on the default config you did remove from /sites-enabled. But it's still present in a /sites-available.

Run into a nginx config error and saw that.

@stefankoerner
Copy link
Contributor Author

Sorry maxpou, i havn't seen your comment. It's exatly what SebTM answered. Thanks

@maxpou
Copy link
Owner

maxpou commented Apr 26, 2017

Great!
Thanks @SebTM @davidbonachera @stefankoerner

@maxpou maxpou closed this Apr 26, 2017
@maxpou maxpou reopened this Apr 26, 2017
@maxpou maxpou merged commit 2d1849a into maxpou:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants