Add /event/party, /payment/method, and new /event/type values #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new event types to support credit application submissions and fund transfer transactions in the minFraud API. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added new party field to indicate whether an agent or customer is submitting the transaction. The party field accepts AGENT and CUSTOMER enum values and is serialized as lowercase in JSON requests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds new input fields and enumeration values to the MinFraud Java API, specifically adding /event/party and /payment/method fields along with new event type values.
- Added
Partyenum to Event class with AGENT and CUSTOMER values - Added
Methodenum to Payment class with various payment method types - Added CREDIT_APPLICATION and FUND_TRANSFER to the Event.Type enum
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/maxmind/minfraud/request/Event.java | Added Party enum and party field with getter/setter methods |
| src/main/java/com/maxmind/minfraud/request/Payment.java | Added Method enum and method field with getter/setter methods |
| src/test/java/com/maxmind/minfraud/request/EventTest.java | Added tests for new party field and event type values |
| src/test/java/com/maxmind/minfraud/request/PaymentTest.java | Added tests for new payment method field |
| README.md | Updated example to show usage of new party field |
| CHANGELOG.md | Documented the new features and breaking changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Added new method field to specify the payment method associated with the transaction. The method field accepts values like CARD, DIGITAL_WALLET, BUY_NOW_PAY_LATER, CRYPTO, and others, serialized as lowercase with underscores in JSON requests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
horgh
force-pushed
the
wstorey/eng-2869-eventparty-and-paymentmethod-minfraud-inputs-are-supported
branch
from
415b745 to
253d5d1
Compare
oschwald
requested changes
Sep 16, 2025
Updated JSON test files and RequestTestHelper to include the new party field (customer) in event objects and method field (card) in payment objects, ensuring complete test coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
approved these changes
Sep 17, 2025
oschwald
deleted the
wstorey/eng-2869-eventparty-and-paymentmethod-minfraud-inputs-are-supported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.