Add a way to run multithreaded lookups in mmdblookup #154
Conversation
horgh
force-pushed
the
will2/multithreaded-mmdblookup
branch
from
de969ca to
78aabad
Compare
This is similar to the existing benchmark mode, but runs in several threads.
horgh
force-pushed
the
will2/multithreaded-mmdblookup
branch
from
78aabad to
ec604d7
Compare
horgh
changed the title
|
Not too certain about the Windows detection here. Also, perhaps this would be better as a separate program, or be combined more with the existing benchmark code. Possibly it doesn't belong in this repo at all. I did find it useful for finding one race, so I think it or something like it would be good to have somewhere. |
bin/mmdblookup.c
Outdated
| @@ -131,13 +164,14 @@ LOCAL const char **get_options(int argc, char **argv, char **mmdb_file, | |||
| { "verbose", no_argument, 0, 'v' }, | |||
| { "version", no_argument, 0, 'n' }, | |||
| { "benchmark", required_argument, 0, 'b' }, | |||
| { "threads", required_argument, 0, 't' }, | |||
There was a problem hiding this comment.
Could we remove this option on Windows?
bin/mmdblookup.c
Outdated
| int const iterations) | ||
| { | ||
| #ifdef _WIN32 | ||
| return false; |
There was a problem hiding this comment.
Why not just remove the function definitions for these on Windows altogether and remove the following?
Lines 82 to 89 in ec604d7
There was a problem hiding this comment.
Yeah, that's nicer. Mainly I was trying to work around regen-prototypes.pl not being happy with macros (it deletes them from its section). I found a different workaround that seems better, although is still a bit ugly what with the extra NO_PROTOTYPE macro. I wonder if we need regen-prototypes.pl. It's not a huge pain to keep them up to date manually and would avoid this problem.
There was a problem hiding this comment.
Yeah, I would be fine getting rid of that script. I don't find it particularly useful.
This is similar to the existing benchmark mode, but runs in several
threads.