Adds ability to pass an open file descriptor to the Reader class. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of a string path to the database.
Member
|
Thanks! |
oschwald
added a commit
that referenced
this pull request
May 16, 2018
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR is complementary to maxmind/MaxMind-DB-Reader-python#33, allowing one to pass an open file descriptor to the
Reader()class upon instantiation (instead of just a string path to the database). The comments in the PR just referenced include a longer reasoning/use-case for this functionality.Since none of the current unit tests instantiate a
Reader()object with an explicitmode, I've just added a small stub test class namedTestFDReader(not a subclass ofBaseTesteReader), which currently does nothing. It's a placeholder and reminder that it could be used in the future.