Fix City constructor from empty subdivisions #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error: ```Cannot assign null to property GeoIp2\Model\City::$mostSpecificSubdivision of type GeoIp2\Record\Subdivision``` Which happens for example for IP from Hongkong.
Contributor
|
In which database did you see this? It seems unexpected to have records that would hit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error:
Cannot assign null to property GeoIp2\Model\City::$mostSpecificSubdivision of type GeoIp2\Record\SubdivisionWhich happens for example for IP from Hongkong.