Skip to content

Conversation

@reedy
Copy link
Contributor

@reedy reedy commented Feb 1, 2022

No description provided.

@reedy
Copy link
Contributor Author

reedy commented Feb 1, 2022

Is examples/benchmark.php really needed to?

@oschwald
Copy link
Member

oschwald commented Feb 1, 2022

I think it makes sense to have the examples in the GitHub tarball and zip files. Adding them here would prevent that.

There has been some debate about whether we should use .gitattributes in this matter at all. See, e.g., maxmind/MaxMind-DB-Reader-php#55.

I'll merge this for now though as it just updates the existing list to be more correct. Thanks!

@oschwald oschwald merged commit cc52ea4 into maxmind:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants