Update README.md #182
Merged
Update README.md #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mention of 3rd-party tool Geoip2-update
oschwald
requested changes
Dec 10, 2021
README.md
Outdated
| site.](https://dev.maxmind.com/geoip/updating-databases?lang=en) | ||
|
|
||
| There is also a third-party tool for updating databases using PHP and | ||
| composer. MaxMind does not offer support for this tool or maintain it. |
Member
There was a problem hiding this comment.
"Composer" should be capitalized unless you are referring to the command, in which case it should be surrounded by backtickers.
README.md
Outdated
|
|
||
| There is also a third-party tool for updating databases using PHP and | ||
| composer. MaxMind does not offer support for this tool or maintain it. | ||
| [Learn more about the Geoip2-update tool for PHP and composer on its |
Member
There was a problem hiding this comment.
Their GitHub project refers to the tool as "Geoip2 Update".
README.md
Outdated
| There is also a third-party tool for updating databases using PHP and | ||
| composer. MaxMind does not offer support for this tool or maintain it. | ||
| [Learn more about the Geoip2-update tool for PHP and composer on its | ||
| github page.](https://github.com/tronovav/geoip2-update) |
README.md
Outdated
|
|
||
| You can keep your databases up to date with our | ||
| [GeoIP Update program](https://github.com/maxmind/geoipupdate/releases). | ||
| [Learn more about GeoIP Update on our developer's |
Member
There was a problem hiding this comment.
Maybe "developer portal" instead as that is what the site refers to itself as? The primary reason I am commented is I wasn't sure if this should be singular or plural or possessive or not.
oschwald
requested changes
Dec 15, 2021
README.md
Outdated
| [Learn more about the Geoip2-update tool for PHP and composer on its | ||
| github page.](https://github.com/tronovav/geoip2-update) | ||
| Composer. MaxMind does not offer support for this tool or maintain it. | ||
| [Learn more about the Geoip2 Update tool for PHP and composer on its |
Make requested change
oschwald
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mention of 3rd-party tool Geoip2-update