-
Notifications
You must be signed in to change notification settings - Fork 1
[Multi Async Eval Configs] - Docs update #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10-28-_live_trends_docs_creation
Are you sure you want to change the base?
[Multi Async Eval Configs] - Docs update #160
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughAdded documentation describing support for multiple auto-evaluation configurations for log repositories: a new "Multiple configurations for auto evaluations" section with steps to add and modify configs, a note under the "Navigate to repository" step referencing that section, and duplicate reinsertion of the section elsewhere in the document. (42 words) Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
online-evals/via-ui/set-up-auto-evaluation-on-logs.mdx (1)
206-217: Consider: Reorganize section for improved content flow (optional).The new "Multiple configurations for auto evaluations" section is clear and well-written. However, it might be more intuitive if placed immediately after the main "Setting Up Auto Evaluation" section (after line 138) rather than after "Making Sense of Evaluations on Logs." This would group related configuration tasks together and create a cohesive setup workflow before moving to results interpretation.
Current placement remains acceptable and follows a reasonable progression.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
images/docs/configure_eval.pngis excluded by!**/*.png
📒 Files selected for processing (1)
online-evals/via-ui/set-up-auto-evaluation-on-logs.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
🔇 Additional comments (1)
online-evals/via-ui/set-up-auto-evaluation-on-logs.mdx (1)
70-73: Approve: Clear contextual guidance on multiple configurations.The Note is well-placed within the step and appropriately introduces the feature. The anchor link format is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
images/docs/configure_eval.pngis excluded by!**/*.png
📒 Files selected for processing (1)
online-evals/via-ui/set-up-auto-evaluation-on-logs.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
🔇 Additional comments (1)
online-evals/via-ui/set-up-auto-evaluation-on-logs.mdx (1)
70-73: Verify the section reference in the Note.The Note references the new section correctly via
#multiple-configurations-for-auto-evaluations. However, ensure all other cross-references in the document are also accurate. A cross-reference issue is noted below.
70320a5 to
5e17f56
Compare
13f2898 to
36a9be3
Compare
Merge activity
|
36a9be3 to
d9f5678
Compare
5e17f56 to
9b1bdad
Compare

No description provided.