Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Lib): Use commander library rather than minimist for more #7

Merged
merged 1 commit into from
Aug 26, 2019
Merged

refactor(Lib): Use commander library rather than minimist for more #7

merged 1 commit into from
Aug 26, 2019

Conversation

zakhenry
Copy link
Collaborator

expansible command structure.

@zakhenry zakhenry mentioned this pull request Jul 13, 2019
Open
maxime1992
maxime1992 requested changes Jul 17, 2019
View reviewed changes
Copy link
Owner

@maxime1992 maxime1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things otherwise LGTM

src/dev-to-git.interface.ts Show resolved Hide resolved
src/dev-to-git.ts Outdated Show resolved Hide resolved
@maxime1992
Copy link
Owner

Also, the CI is failing

@maxime1992 maxime1992 self-requested a review August 26, 2019 07:09
maxime1992
maxime1992 approved these changes Aug 26, 2019
View reviewed changes
Copy link
Owner

@maxime1992 maxime1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😸 👏

@maxime1992 maxime1992 merged commit 1d7a972 into maxime1992:master Aug 26, 2019
@maxime1992
Copy link
Owner

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime1992 maxime1992 maxime1992 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakhenry @maxime1992 @zak-cloudnc