Merge pull request #11 from BBlackwo/dev-bblackwo-only-update-relativ…

…e-images fix(article): only update links for relative images
maxime1992 · Aug 26, 2019 · 0eb6607 · 0eb6607
2 parents 1d7a972 + a1acabd
commit 0eb6607
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/article.spec.ts b/src/article.spec.ts
@@ -39,5 +39,9 @@ describe(`Article`, () => {
         `Image 3: ![alt text 3](https://raw.githubusercontent.com/${repository.username}/${repository.name}/master/test/image-3.png)`,
       );
     });
+
+    it(`should NOT rewrite absolute images URLs to match the raw file on github`, () => {
+      expect(articleRead).toContain(`Absolute image: ![alt text](http://google.com/absolute-image.png)`);
+    });
   });
 });
diff --git a/src/article.ts b/src/article.ts
@@ -7,7 +7,7 @@ interface ArticleFrontMatter {
   title: string;
 }
 
-const imagesRe: RegExp = /\!\[.*\]\(.*\)/g;
+const imagesRe: RegExp = /\!\[.*\]\(\.\/.*\)/g;
 const imageRe: RegExp = /\!\[(.*)\]\(([^ \)]*)(?: '(.*)')?\)/;
 
 const excludeArticleFromPath = (path: string): string => path.replace(/\/[^\/]+\.md$/, '');

diff --git a/test/article.md b/test/article.md
@@ -9,10 +9,16 @@ canonical_url:
 
 # This is my awesome article!
 
+## Relative images
+
 Hey, some text!
 
 Image 1: ![alt text 1](./image-1.png 'Title image 1')
 
 Image 2: ![alt text 2](./image-2.png 'Title image 2')
 
 Image 3: ![alt text 3](./image-3.png)
+
+## Absolute images
+
+Absolute image: ![alt text](http://google.com/absolute-image.png)