Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change is a repo-wide review and cleanup pass focused on accuracy, maintainability, and config drift across the Home Assistant setup.
It fixes a handful of stale/broken references, improves a few template sensors and automations, cleans up old dead config paths, and updates documentation so the repo better matches the current live setup.
What changed
Fixed stale entity references that no longer matched the current setup.
sensor.maxi_location_by_petro_v2reference withsensor.maxi_location_by_petro.vacuum.xiaomi_vacuum_cleanerreferences withvacuum.roborock_qrevo_curv_serieswhere appropriate.Fixed automation/script behavior that was incorrect or misleading.
input_boolean.live_concertto turn off before restoring the tablet interfaces.wait_for_trigger: []behavior from the broadcast script.Improved template sensor correctness and metadata.
Outside Temperature with Fallbackto return a safer fallback value and use proper temperature metadata.Maxi current Activity V2to use the current Roborock cleaning state instead of the old Xiaomi vacuum entity.Average House Humidityso the sensor better reflects indoor conditions.Reduced config drift and dead paths.
includes/automations.yamlfile out of the active path toincludes/automations.yaml.unusedso edits are less likely to land in a dead file.Cleaned up repo documentation.
wip list.mdso the README no longer points to a missing file.node-red/README.mdto document that old Node-RED flow exports are no longer tracked.Intentional TODOs / preserved behavior
Some existing behavior was intentionally preserved even though it is not ideal, because it is still relied on today. These are now marked with
TODOcomments so they can be called out and cleaned up later:localStorage.These behaviors were preserved on purpose for compatibility and should be treated as follow-up security debt.
Validation
appdaemon/apps/get_token.pycompiles successfullyI could not run a full Home Assistant
ha core checkin this workspace because the HA CLI/runtime is not available locally.