Skip to content

fix!: work around Pandoc 3.2+ breaking links to chapters #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 25, 2024
Merged

fix!: work around Pandoc 3.2+ breaking links to chapters #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
97e7a08
WIP: work around pandoc 3.2 no longer wrapping file contents in divs
max-heller Jun 23, 2024
f3a8719
fix(tests): update snapshot for pandoc 3.2
max-heller Jun 23, 2024
973aaf0
fix(tests): add chapter heading
max-heller Jun 23, 2024
c82e1e0
Merge branch 'main' into pandoc-3.2
max-heller Jun 24, 2024
a9447b5
add test for remote redirect
max-heller Jun 24, 2024
a8d4581
fix: properly anchor redirected links
max-heller Jun 24, 2024
c820751
Merge branch 'main' into pandoc-3.2
max-heller Jun 24, 2024
a64ba7b
fixes
max-heller Jun 25, 2024
4a5a9ab
chore(tests): update snapshots
max-heller Jun 25, 2024
9dbe887
chore(ci): use `pandoc` 3.2 in CI
max-heller Jun 25, 2024
1189b69
docs(README): document new state of mostly-reliable chapter links
max-heller Jun 25, 2024
ebcaadc
cleanup
max-heller Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ variable-name = "value"

### Known Issues

- When rendering to PDF through LaTeX, links to chapters sometimes link to slightly before the beginning of the chapter.
See: https://github.com/jgm/pandoc/issues/9200
- Linking to a chapter does not work unless the chapter contains a heading with a non-empty identifier (either auto-generated or explicitly specified).
See: https://github.com/max-heller/mdbook-pandoc/pull/100

### Comparison to alternatives

Expand Down
6 changes: 3 additions & 3 deletions scripts/install-ci-deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ sudo apt-get update
curl -LsSf https://get.nexte.st/0.9/linux | tar zxf - -C ${CARGO_HOME:-~/.cargo}/bin

# Pandoc
curl -LsSf https://github.com/jgm/pandoc/releases/download/3.1.12.3/pandoc-3.1.12.3-linux-amd64.tar.gz | tar zxf -
echo "$PWD/pandoc-3.1.12.3/bin" >> $GITHUB_PATH
export PATH="$PWD/pandoc-3.1.12.3/bin:$PATH"
curl -LsSf https://github.com/jgm/pandoc/releases/download/3.2/pandoc-3.2-linux-amd64.tar.gz | tar zxf -
echo "$PWD/pandoc-3.2/bin" >> $GITHUB_PATH
export PATH="$PWD/pandoc-3.2/bin:$PATH"

# rsvg-convert (SVG support)
sudo apt-get install -y librsvg2-bin
Expand Down
Loading
Loading