Missing chapters in table of contents

[jamesst20]

Hi,

First of all, thank you for your hardwork, this plugin is very useful.

I am trying to generate EPUB using mdbook-pandoc in this project: https://github.com/rust-lang/book

I have updated the book.toml to inclucde

[output.pandoc.profile.epub3]
output-file = "output.epub"
to = "epub3"
file-scope = true
number-sections = true
standalone = true
table-of-contents = true
toc-depth = 3

[output.pandoc]
hosted-html = "https://doc.rust-lang.org/nightly/book/"

[output.pandoc.code]
show-hidden-lines = false

But this seem to only generate first level:

Weirdly, if I change each sub-markdown like chXX-01, chXX-02, etc. to start with a # instead of a ## now it will include them.

I am not sure if this is a bug or something I am missing. Running instead of mdbook build this pandoc src/*.md -o output.epub will generate the proper level of table of content.

Thanks in advance

[max-heller]

Weirdly, if I change each sub-markdown like chXX-01, chXX-02, etc. to start with a # instead of a ## now it will include them.

This is the problem, mdbook-pandoc expects books to use the same heading levels for nested chapters as they do for top-level chapters, but the Rust Book breaks this assumption. If you look at a book like the Cargo Book that uses # for the headings at the beginning of each chapter, the TOC renders correctly.

This behavior is mentioned in the README, although I didn't realize how buggy it was 😢:

In order to make section numbers and the generated table of contents, if applicable, mirror the chapter hierarchy defined in SUMMARY.md:

• Headings in nested chapters are shrunk one level per level of nesting
• All headings except for H1s are marked as unnumbered and unlisted

I'm not sure the best way to deal with the Rust Book's style. Ideally, we'd be able to create the TOC based on SUMMARY.md, but Pandoc's TOC generation works based on headings contained in the document, which are not necessarily the same as the SUMMARY.md chapter names. If we could create invisible headings in the source with the proper names of the chapters from SUMMARY.md, things would just work, but I'm not sure how to make such an invisible heading.

To make the current approach work for the Rust Book, it might make sense to either:

• Increase the size of all headings in chapters that do not contain any H1s (#), or
• Only mark headings smaller than the largest heading in each chapter as unnumbered and unlisted

I'll play around with those options and see which makes more sense.

First of all, thank you for your hardwork, this plugin is very useful.

Thank you, I'm glad you find it useful!

[jamesst20]

In Rust book, every

• chXX-00 contains only its top level chapter content
• chXX-YY contains only this sub level chapter content

So no markdown file contains more than one 'part' of a chapter. This also means that every markdown file starts with the heading expected to be in the TOC and that's also the only expected heading for that file to be present in the TOC. Typically any chXX-00 will be # heading and any chXX-YY will be ## heading.

Your suggestion

• Only mark headings smaller than the largest heading in each chapter as unnumbered and unlisted

If you mean by that "smaller than the first heading at the top of every markdown file", maybe it would work because by looking quickly it seems to always be the case

[max-heller]

Can you try the fix in #182? It should fix the TOC for the Rust Book.

cargo install mdbook-pandoc --git https://github.com/max-heller/mdbook-pandoc --branch rust-book-toc

Note that toc-depth = 3 will still only show two levels in the Rust Book because the Rust Book contains no doubly-nested chapters, and mdbook-pandoc, like mdbook but unlike pandoc, generates the TOC based on chapter hierarchy instead of all headings.

[jamesst20]

Can you try the fix in #182? It should fix the TOC for the Rust Book.

cargo install mdbook-pandoc --git https://github.com/max-heller/mdbook-pandoc --branch rust-book-toc
Note that toc-depth = 3 will still only show two levels in the Rust Book because the Rust Book contains no doubly-nested chapters, and mdbook-pandoc, like mdbook but unlike pandoc, generates the TOC based on chapter hierarchy instead of all headings.

This works flawlessly!! Thank you!

I would have an extra request if you are up to it!
Here:

mdbook-pandoc/src/preprocess/code.rs

Lines 15 to 46 in 29e4e36

	impl<'book> CodeBlock<'book> {
	pub fn new(kind: &'book CodeBlockKind<'_>, cfg: Option<&'book mdbook::config::Code>) -> Self {
	// MdBook supports custom attributes in code block info strings.
	// Attributes are separated by a comma, space, or tab from the language name.
	// See https://rust-lang.github.io/mdBook/format/mdbook.html#rust-code-block-attributes
	// This processes and strips out the attributes.
	let (language, mut attributes) = {
	let info_string = match kind {
	CodeBlockKind::Indented => "",
	CodeBlockKind::Fenced(info_string) => info_string,
	};
	let mut parts = info_string.split([',', ' ', '\t']).map(|part| part.trim());
	(parts.next(), parts)
	};
	match language {
	Some("rust") => Self::Rust,
	language => {
	let hidelines_override =
	attributes.find_map(|attr| attr.strip_prefix("hidelines="));
	let hidelines_prefix = hidelines_override.or_else(|| {
	// Respect [output.html.code.hidelines]
	Some(cfg?.hidelines.get(language?)?.as_str())
	});
	Self::Other {
	language,
	hidelines_prefix,
	}
	}
	}
	}
	}

I believe it's where you are stripping the attributes from blocks like these

\  ```rust,ignore,does_not_compile
\  {{#rustdoc_include ../listings/ch09-error-handling/listing-09-10/src/main.rs}}
\  ```

I was wondering if it was possible to either add the ability to extend the classes to keep or have these included in the output? It would allow styling blocks for exemple that does not compile

Thanks again!

[max-heller]

I was wondering if it was possible to either add the ability to extend the classes to keep or have these included in the output? It would allow styling blocks for exemple that does not compile

That sounds very doable, could you open a new issue?