Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Simple launch file #1747

Closed
wants to merge 13 commits into from
Closed

Conversation

Ryujiyasu
Copy link

  1. separate param file from launch folder
  2. delete ros launch files
  3. make simple launch file

mavros/launch/node.launch.py Outdated Show resolved Hide resolved
mavros/param/mavros_params.yaml Outdated Show resolved Hide resolved
@vooon vooon added the ros2 label May 17, 2022
@Ryujiyasu
Copy link
Author

Ryujiyasu commented May 18, 2022

@vooon
which plugin name is correct
px4flow->"px" or "px4flow"

@vooon
Copy link
Member

vooon commented May 18, 2022

: Plugin(uas_, "px4flow"),

Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase PR.

mavros/param/config.yaml Outdated Show resolved Hide resolved
<description>@brief Wind estimation plugin.
@plugin wind_estimation</description>
@plugin mavros/wind_estimation</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! You should not do that! Each plugin is subnode to mavros::uas::UAS, so if you start it with different name, you'll get different prefix.

@vooon vooon mentioned this pull request Jul 17, 2022
@@ -4,138 +4,138 @@ import mavros_cog

mavros_cog.outl_plugins_xml('src/plugins', 'mavros_plugins')
]]] -->
<library path="mavros_plugins">
<library path="mavros/mavros_plugins">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this breaks whole thing and nothing works 😆

So use just:

<library path="mavros_plugins">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file should not be changed at all.

Copy link

@eMrazSVK eMrazSVK Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, I successfully launched ros2 launch mavros node.launch.py with unchanged mavros_plugins.xml so the changes for this file can be removed/not applied.

Tested with SITL ArduCopter V4.2.3-rc2

@Ryujiyasu

@vooon
Copy link
Member

vooon commented Feb 24, 2023

Replaced by #1834

@vooon vooon closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants