make Simple launch file #1747
Closed
make Simple launch file #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryujiyasu
commented
May 17, 2022
Ryujiyasu
commented
- separate param file from launch folder
- delete ros launch files
- make simple launch file
vooon
reviewed
May 17, 2022
|
@vooon |
vooon
requested changes
May 20, 2022
| <description>@brief Wind estimation plugin. | ||
| @plugin wind_estimation</description> | ||
| @plugin mavros/wind_estimation</description> |
There was a problem hiding this comment.
No! You should not do that! Each plugin is subnode to mavros::uas::UAS, so if you start it with different name, you'll get different prefix.
eMrazSVK
reviewed
Sep 20, 2022
| @@ -4,138 +4,138 @@ import mavros_cog | |||
|
|
|||
| mavros_cog.outl_plugins_xml('src/plugins', 'mavros_plugins') | |||
| ]]] --> | |||
| <library path="mavros_plugins"> | |||
| <library path="mavros/mavros_plugins"> | |||
There was a problem hiding this comment.
Actually, this breaks whole thing and nothing works 😆
So use just:
<library path="mavros_plugins">
There was a problem hiding this comment.
That file should not be changed at all.
There was a problem hiding this comment.
Confirmed, I successfully launched ros2 launch mavros node.launch.py with unchanged mavros_plugins.xml so the changes for this file can be removed/not applied.
Tested with SITL ArduCopter V4.2.3-rc2
|
Replaced by #1834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.