Examples cleanup #568
Merged
Examples cleanup #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the pygame example doesn't work well together with async Python and can therefore be confusing for someone trying to learn it. If pygame is used with asyncio it requires a separate task with a queue for communication. Also see: https://github.com/AlexElvers/pygame-with-asyncio/ Signed-off-by: Julian Oes <julian@oes.ch>
I had broken them previously when removing the deprecated get_event_loop calls. Signed-off-by: Julian Oes <julian@oes.ch>
This fixes what pycodestyle complains about which was formerly known as the PEP8 checker. Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-example-cleanup
branch
from
83e0e39 to
9454a9b
Compare
Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-example-cleanup
branch
from
9454a9b to
942834e
Compare
JonasVautherin
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the pygame example doesn't work well together with async Python and can therefore be confusing for someone trying to learn it.
If pygame is used with asyncio it requires a separate task with a queue for communication. Also see:
https://github.com/AlexElvers/pygame-with-asyncio/
Also, this fixes up the telemetry examples I had broken them previously when removing the deprecated get_event_loop
calls.
And while I was at it, I enabled pycodestyle in CI and fixed up the examples.
Closes #567