Skip to content

Fix macos ci #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Fix macos ci #538

merged 1 commit into from
Dec 23, 2022

Conversation

JonasVautherin
Copy link
Collaborator

For some reason it started failing with error: invalid command 'bdist_wheel'.

@JonasVautherin JonasVautherin force-pushed the fix-ci-macos branch 4 times, most recently from 19e7c0e to 4232e34 Compare December 22, 2022 10:47
@JonasVautherin
Copy link
Collaborator Author

I am a bit puzzled, because it was very painful to get to those two lines. I am not entirely sure if those two lines generally work or if I have just been lucky in the last 4 runs.

At least they make sense, so... let's try with them maybe?

@@ -125,7 +125,7 @@ jobs:

macOS:
name: macOS
runs-on: macos-latest
runs-on: macos-12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So according to what I read this should be the same. Although I'm fine pinning this to avoid breakage.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, but before I changed it, it was failing 🤔. So I don't know if something else changed during my tests, or if that is different, but I'm a bit confused.

@@ -140,7 +140,7 @@ jobs:
- name: Install prerequisites
run: |
python3 -m pip install -r requirements.txt
python3 -m pip install twine
python3 -m pip install twine wheel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen that before, probably makes sense.

Why did you remove twine? I believe that's required to publish the release, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not, it's right before wheel 😆. What time was it when you read that? 😁

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh. Thanks.

@julianoes julianoes merged commit c493e52 into main Dec 23, 2022
@julianoes julianoes deleted the fix-ci-macos branch December 23, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants