Skip to content

system: allow setting sysid/compid #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

system: allow setting sysid/compid #407

merged 1 commit into from
Nov 30, 2021

Conversation

julianoes
Copy link
Collaborator

This allows to set the sysid and compid of the MAVSDK server but not actually the system, so the API is slightly odd.

@julianoes
system: allow setting sysid/compid
58f5596 
This allows to set the sysid and compid of the MAVSDK server but not
actually the system, so the API is slightly odd.
JonasVautherin
JonasVautherin approved these changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it may be a bit confusing if you use another mavsdk_server than the embedded one, because those arguments won't have any effect then.

But well... 😆

@julianoes julianoes merged commit 8ca8390 into main Nov 30, 2021
@julianoes julianoes deleted the pr-sysid-compid branch November 30, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianoes @JonasVautherin