Use != instead of is not for values.
#395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the `==`/`!=` operators instead of `is`/`is not` when checking the return value of RPC calls. In Python, `is not` tests if the two operands are the same object whereas `!=` test that they have the same value. `is not` just happens to work for small integers due to an implementation detail in CPython (e.g. see [StackOverflow][1]). [1]: https://stackoverflow.com/a/133024/1976323
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
==/!=operators instead ofis/is notwhen checking the return value of RPC calls. In Python,is nottests if the two operands are the same object whereas!=test that they have the same value.is notjust happens to work for small integers due to an implementation detail in CPython (e.g. see StackOverflow).