Skip to content

examples: closer goto, and go up, not down #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Conversation

julianoes
Copy link
Collaborator

This is required because the goto altitude is absolute.

This is required because the goto altitude is absolute.
@iwishiwasaneagle
Copy link

iwishiwasaneagle commented Jul 23, 2020

@julianoes does this work with plane?

Edit: works on my end, however you need to specify heading angle as float('nan') otherwise the plane will crash as before.

@julianoes
Copy link
Collaborator Author

@iwishiwasaneagle do you know why the plane crashes? Is it just because it's too low for it do to crazy turns?

@iwishiwasaneagle
Copy link

@iwishiwasaneagle do you know why the plane crashes? Is it just because it's too low for it do to crazy turns?

Well the docs for (MAV_CMD_DO_REPOSITION)[https://mavlink.io/en/messages/common.html#MAV_CMD_DO_REPOSITION] say that for planes, yaw angle should either be 0 or 1 for loiter direction. However, as soon as I do either of those my SITL Plane loses complete control.

Yaw heading. NaN to use the current system yaw heading mode (e.g. yaw towards next waypoint, yaw to home, etc.). For planes indicates loiter direction (0: clockwise, 1: counter clockwise)

Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yaw_deg should default to 'nan' then.

@julianoes julianoes merged commit 493329d into master Jul 27, 2020
@julianoes julianoes deleted the pr-goto-closer branch July 27, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants