Merged
Conversation
escopecz
requested changes
Jul 12, 2023
Member
|
Oh, and please rebase this to the 5.x branch. |
roboparker
force-pushed
the
custom-fields-chron
branch
from
1f06a37 to
0ba6f7d
Compare
Contributor
Author
|
@escopecz Rebased. Should the PR merge into 5.x instead of main? |
Member
|
Yes. I changed that. Thanks! |
escopecz
changed the title
escopecz
previously approved these changes
Jul 20, 2023
roboparker
force-pushed
the
custom-fields-chron
branch
from
0ba6f7d to
2cea243
Compare
RCheesley
requested changes
Aug 8, 2023
Member
RCheesley
left a comment
RCheesley
left a comment
There was a problem hiding this comment.
Coupled of small suggestions, thanks @diaboloshogunate 🚀
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding docs for custom fields cron job
PR: mautic/mautic#12508