Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make port 80 redirect to SSL #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aspiers
Copy link
Contributor

@aspiers aspiers commented Jun 2, 2019

These days it's generally accepted that best practice is to use SSL
everywhere, since unencrypted traffic is susceptible to all kinds of
security and privacy issues.

Adam Spiers added 2 commits June 2, 2019 14:17
These days it's generally accepted that best practice is to use SSL
everywhere, since unencrypted traffic is susceptible to all kinds of
security and privacy issues.
It was a mix of tabs and spaces, and the tabs were obviously meant to
be interpreted as being 4 columns wide, which is a much less common
interpretation than 8 columns.  So make the file self-consistent and
unambiguous by replacing each tab with 4 spaces.
@luizeof
Copy link
Member

luizeof commented Jun 7, 2019

@aspiers many users prefer use an reverse proxy like traefik or jwilder-nginx-proxy

@aspiers
Copy link
Contributor Author

aspiers commented Jun 8, 2019

@luizeof This docker-compose.yml file already sets up nginx as a reverse proxy so I'm not sure what your point is here, or how that's related to this PR?

@luizeof
Copy link
Member

luizeof commented Jul 16, 2019

Hi @aspiers you can use the image https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion side by side within nginx-proxy ... this image provide the necessary let's encrypt features to nginx-proxy

@aspiers
Copy link
Contributor Author

aspiers commented Aug 27, 2019

@luizeof Thanks for the link. I already used this one to get letsencrypt set up. I still don't understand setting up letsencrypt or your previous comment about reverse proxies relate to this PR though. This PR is simply about redirecting from non-SSL to SSL, which is best practice in every case, independently of how SSL is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants